-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Show stem slash' property for all grace notes #20890
Conversation
2e9405e
to
3e20e58
Compare
3e20e58
to
fd20871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a great little feature!
Two problems that need resolving before merging:
- Stem slashes are not populating to parts
- The new "show stem slash" checkbox should be disabled when "stemless" is selected
Here is the test score I am using:
stem-slash-feature.mscz.zip
Thanks!
70bebe8
to
b2f89ae
Compare
Point 2 has been addressed! For point 1, it seems that the property doesn't set for parts or linked staves, until the value is edited manually (works fine after that). I haven't yet been able to work out why... |
Random guess: perhaps you need to add something in the copy constructor of Chord? (chord.cpp line 281) |
b2f89ae
to
245f58e
Compare
Ah, so that's what that method is for... |
f223d8f
to
a8d57be
Compare
The changes are all accounted for @bkunda! |
@XiaoMigros A rebase is needed due to recent changes in the MusicXML module |
a8d57be
to
d8df80a
Compare
This PR introduces a property 'Show stem slash' for all grace notes. The slash is shown by default for acciaccaturas, and is toggleable for all grace notes on a per-beam basis.