Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on barlines not show #21728

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mike-spa
Copy link
Contributor

Resolves: #21485

@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Feb 28, 2024
@@ -985,6 +985,7 @@ void TLayout::layoutBarLine(const BarLine* item, BarLine::LayoutData* ldata, con
if (item->staff() && item->segment()) {
if ((!item->staff()->staffTypeForElement(item)->showBarlines() && item->segment()->segmentType() == SegmentType::EndBarLine)
|| (item->staff()->hideSystemBarLine() && item->segment()->segmentType() == SegmentType::BeginBarLine)) {
ldata->setPos(PointF());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mu3 has that right before the 1st if

@mike-spa mike-spa merged commit 80362f0 into musescore:master Feb 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mixing staves with both hidden and unhidden barlines opens pandora's box
4 participants