fix #75826: barline offset not saved #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschweer
added a commit
that referenced
this pull request
Oct 28, 2015
fix #75826: barline offset not saved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, it never really occured to me we even supported user offsets on barlines. But it does work, other than being lost on save / reload. And I think the only reason it gets lost on save/reload is because the generated flag never gets set. I added a check to the place we check the other properties that can affect generated status, and it works for the cases I tried. I know management of barlines is complex and delicate, but I'm pretty sure this change should be safe.