Add option to have long, short or hidden instrument names #22550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
18289-instr-names
branch
2 times, most recently
from
1cc5e41
to
da7dae3
Compare
oktophonie
approved these changes
Apr 29, 2024
miiizen
force-pushed
the
18289-instr-names
branch
from
da7dae3
to
26b06f0
Compare
miiizen
force-pushed
the
18289-instr-names
branch
from
26b06f0
to
46d45c5
Compare
| || (ctx.conf().styleB(Sid::hideInstrumentNameIfOneInstrument) && ctx.dom().visiblePartCount() <= 1)) { | ||
| || (ctx.conf().styleB(Sid::hideInstrumentNameIfOneInstrument) && ctx.dom().visiblePartCount() <= 1) | ||
| || (ctx.state().firstSystem() | ||
| && ctx.conf().styleV(Sid::firstSystemInstNameVisibility).value<InstrumentLabelVisibility>() == InstrumentLabelVisibility::HIDE) |
There was a problem hiding this comment.
The only suggestion I have is to try to simplify this (for example, by adding temp bool variables). You can do this in your next PR
RomanPudashkin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18289
Resolves: #22345
This PR adds style options which allow instrument names to be long, short, or hidden, with separate options for the first system of a section and subsequent systems.
This also contains updates to the templates to make use of this change (eg. reinstating instrument names to the voice & piano template) and additional updates to instrument names to more closely follow the information in instruments.xml