Set notehead scheme from XML <notehead> tag
#22576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
changed the title
notehead tag<notehead> tag
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
miiizen
force-pushed
the
xml-named-noteheads
branch
from
6689526
to
99cdf4a
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 25, 2024
| @@ -5957,6 +5958,8 @@ Note* MusicXMLParserPass2::note(const String& partId, | |||
| auto noteheadValue = m_e.readText(); | |||
| if (noteheadValue == "none") { | |||
| hasHead = false; | |||
| } else if (noteheadValue == "named") { | |||
There was a problem hiding this comment.
Such a notehead type doesn't exist in MusicXML, see https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/notehead/ and https://www.w3.org/2021/06/musicxml40/musicxml-reference/data-types/notehead-value/
Esp. this:
Noteheads in the SMuFL Note name noteheads and Note name noteheads supplement ranges (U+E150–U+E1AF and U+EEE0–U+EEFF) should not use the smufl attribute or the other value, but instead use the <notehead-text> element.
There was a problem hiding this comment.
Apologies, this is an out of spec case for a single exporter
miiizen
force-pushed
the
xml-named-noteheads
branch
from
99cdf4a
to
c1b1e9e
Compare
miiizen
force-pushed
the
xml-named-noteheads
branch
from
c1b1e9e
to
52306e3
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2024
oktophonie
approved these changes
Apr 26, 2024
RomanPudashkin
approved these changes
Apr 26, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a note's
NoteHeadSchemetoHEAD_PITCHNAMEwhen the value of the<notehead>tag is "named".