Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to volta default positions around clefs, headers and beginning of systems #23166

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Jun 10, 2024

Resolves: #22379
Resolves: #22930

@mike-spa mike-spa requested a review from oktophonie June 10, 2024 09:36
@XiaoMigros
Copy link
Contributor

Should measure-aligned texts follow the same behavior? They already follow something similar for the measure end

@mike-spa
Copy link
Contributor Author

Should measure-aligned texts follow the same behavior? They already follow something similar for the measure end

Voltas are quite peculiar in the way that they align to barlines, repeats etc, so I'm not sure that all of this stuff would translate to other objects. So unless there is a specific issue to fix I'd prefer to not touch other stuff

@oktophonie oktophonie requested a review from miiizen June 10, 2024 16:06
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Jun 10, 2024
@RomanPudashkin RomanPudashkin merged commit 533d423 into musescore:master Jun 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeat line wrong size and position in mmRest mode Clefs placed after the barline offset voltas
4 participants