Fix lyrics odd-even style bug #23868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Aug 2, 2024
|
Especially after this fix, I don't seem to see much benefit in the |
|
See also #23506, I believe the fix from there is also needed |
mike-spa
force-pushed
the
fixLyricsOddEvenStyleBug
branch
from
33c1e65
to
9bd43ed
Compare
Oh yes thanks. That was an absolute horror, happy to get rid of it |
mike-spa
force-pushed
the
fixLyricsOddEvenStyleBug
branch
from
9bd43ed
to
d744017
Compare
mike-spa
force-pushed
the
fixLyricsOddEvenStyleBug
branch
from
d744017
to
0bb2ce2
Compare
No it isn't |
cbjeukendrup
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23846
Additionally, this PR also reintroduces the use of
lineSpacing()for calculating the line height between the different lyrics verses. The metric currently being used waslineHeight(), which I'd recently introduced as a way of getting around #22189. Now that that issue has been fixed,lineSpacing()is the correct metric to use. This will show up in the vtests as a slight increase in vertical distance between the verses.