Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link grace note ties when cloning measures and staves #23899

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Aug 5, 2024

Resolves: #20596

The issue was present whether the grace notes were visible or invisible, and also affected linked staves in the same score.

This PR also links stems and flags between score & parts. Previously, when making a note invisible the notehead, stem and flag would become invisible in the score but in the part only the notehead would be invisible.

oktophonie
oktophonie previously approved these changes Aug 6, 2024
@mike-spa
Copy link
Contributor

mike-spa commented Aug 7, 2024

This PR also links stems and flags between score & parts. Previously, when making a note invisible the notehead, stem and flag would become invisible in the score but in the part only the notehead would be invisible.

Still haven't looked at the code, but I'm slightly hesitant about this (linking stems and flags). First things that came to my mind being:

  • If beamed, the beam slant may slightly differ from score to part (because the angle also depends on horizontal spacing) and therefore also the resulting stem length will differ. Is that going to be a problem? What if I want to manually adjust a beam in the part but not in the score, is having linked stems going to be an issue?
  • Can the chord (this I honestly don't know) be set to a different beaming type in the part than in the score? (and as a result, say, have the flag in the part but be beamed in the score?)

In general, the fact the stems and flags are mostly generated at layout time (and the fact that layout is independent between parts and score) makes me instinctively prefer to not have them linked.

@miiizen
Copy link
Contributor Author

miiizen commented Aug 7, 2024

@mike-spa yeah, I don't love it. I decided to try it so this would use our property management and undo system, although having thought about those reasons, I think controlling these via the chord would be more sensible. This does mean that if you want an invisible stem or flag you'll have to do it manually in both score and part, but that's a limitation we have now (also the stemless setting is there).
I'll go through the linked chords in undoChangeNoteVisibility and use undoChangeProperty to change the visibility of their stems and flags.

@mike-spa mike-spa merged commit 0d4d8be into musescore:master Aug 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tie to hidden grace note after is broken in part
3 participants