fix #78416: Tempo text oddities in score with linked parts until save/reopen #2451
Conversation
|
Some more explanation: the if statement just checked whether the tempotext object itself changed - but it didn't check if the tempo is a different one in the song!
Change from plaintext to xmltext is because plaintext uses _layout which doesn't get updated if the text gets set by the score itself (by method Text::setXmlText) - _layout just gets updated if someone types things into the text |
| score()->fixTicks(); | ||
| score()->setPlaylistDirty(); | ||
| } | ||
| setTempo(nt); |
There was a problem hiding this comment.
we could also just drop the local var nt althogether, as it is used only once.
hpfmn
force-pushed
the
fix-78416
branch
2 times, most recently
from
78a40cf
to
fd05878
Compare
|
won't this PR collide with #2591 ? |
|
yes it will collide - but which one gets merged first - I'll just edit the other one ;) |
…ead of plainText, get rid of nt
|
@lasconic, I may be not the only one to think that this was long since merged, but it seems it wasn't. Would you care to check on it? |
|
Rebase needed |
|
Not only a rebase is needed, it also doesn't seem to work (taking that code and resolving the merge conflicts) |
|
The issue is seemed to be fixed by recent changes in tempo mapping. |
always update tempo on tempotextchange and use _text instead of _layout