fix #116556: Crash by opening the Instruments dialog box after parts … #2739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…deletion and undo
Ms::deleteExcerpt() did not make sure it really uses a staff of the master score to unlink staves of the excerpt. The loop using calls to Staff::primaryStaff() depends on the order of elements in _linkedStaves, since Staff::primaryStaff() will always return true if only two staves of two different scores are in the list.
With the given order of steps in #116556 this could cause the final call to
having (staff == s) both pointing to the same staff in the excerpt. The pointer to _linkedStaves in the master score was therefore never set to 0, while the LinkedStaves object itself was deleted.
Opening the Instruments Dialog window made use of this invalid _linkedStaves pointer and crashed.