Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluegrass, small concert band and small marching band templates; fix #153906: update all templates with instrument definitions for 2.1 #2926

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

IsaacWeiss
Copy link
Contributor

@IsaacWeiss IsaacWeiss commented Dec 27, 2016

Updated all templates containing piccolo, string bass variants and/or "Percussion" staves

Bluegrass and small concert band templates courtesy of Devyn Horne and Kang Yi, see https://musescore.org/en/node/53891

@IsaacWeiss IsaacWeiss changed the title Add bluegrass and small concert band templates Add bluegrass, small concert band and small marching band templates; update all templates with instrument definitions for 2.1 Jan 3, 2017
…fix #153906: update all templates with instrument definitions for 2.1
@IsaacWeiss IsaacWeiss changed the title Add bluegrass, small concert band and small marching band templates; update all templates with instrument definitions for 2.1 Add bluegrass, small concert band and small marching band templates; fix #153906: update all templates with instrument definitions for 2.1 Jan 4, 2017
@lasconic
Copy link
Contributor

lasconic commented Mar 8, 2017

That's a lot of templates... Hopefully we can remove some in an upcoming version...

@lasconic
Copy link
Contributor

lasconic commented Mar 8, 2017

Several templates have already been modified in 2.1

share/templates/05-Jazz/02-Big_Band.mscz
share/templates/05-Jazz/03-Jazz_Combo.mscz
share/templates/06-Popular/01-Rock_Band.mscz
share/templates/08-Orchestral/01-Classical_Orchestra.mscz

@lasconic
Copy link
Contributor

lasconic commented Mar 8, 2017

So if we do want all these templates in 2.1, they need to be redone with recent 2.1 nightly build.

@lasconic lasconic merged commit b520dca into musescore:master Mar 8, 2017
@lasconic
Copy link
Contributor

lasconic commented Mar 8, 2017

I merged the PR in 2.1 too. It would be great if someone could verify that the templates are correct. They do open in 2.1.

@IsaacWeiss
Copy link
Contributor Author

IsaacWeiss commented Mar 9, 2017

Templates were redone with a 2.1 nightly build in January, for the new default instrument definitions. Has anything else changed since then?

As to removing templates, I see them as being very important unless/until MuseScore is able to automatically number instruments, connect barlines, add brackets, and scale staves appropriately when creating a score from scratch—and especially important for 3.0 if no easy way to connect barlines through multiple staves is brought back.

@lasconic
Copy link
Contributor

lasconic commented Mar 9, 2017

and I disagree... We can't measure it but I'm pretty sure that the more we add templates, the less provided templates are used.

no easy way to connect barlines through multiple staves is brought back.
Is there an issue for this one?

@IsaacWeiss
Copy link
Contributor Author

@IsaacWeiss IsaacWeiss deleted the add-templates branch May 20, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants