Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #175886 fretboard to harmony #3205

Merged
merged 4 commits into from
Jun 14, 2017

Conversation

MarcSabatella
Copy link
Contributor

This is a 2.2 version of the PR I submitted for master - #3199. I still need to add another mtest to this, and to update the master version as well.

@MarcSabatella
Copy link
Contributor Author

OK, I think this is ready. IWill now go back to my original PR from master and update that as well. Same PR can't work for both as too many things have changed.

The intent of the changes here is to make fretboard diagrams work more like chord symbols and to make it easier to work with them together. The specific changes:

  1. you can now add a fretboard diagram to a chord symbol rather than just to a note or rest, via drag &
    drop or select / double click (internally it still gets added to the segment)

  2. you can now add a chord symbol to a fretboard diagram via Ctrl+K (again, internally it still gets added to the segment)

  3. you can now copy/paste a list selection of fretboard diagrams same as for chord symbols

The tests added cover the first and third points. The second I don't know that there is a way to test automatically.

@MarcSabatella MarcSabatella force-pushed the 22-175886-fretboard-to-harmony branch from 8071d50 to aa964ea Compare June 12, 2017 22:27
@MarcSabatella
Copy link
Contributor Author

MarcSabatella commented Jun 13, 2017

#3211 should address the most important concerns I have - bugs that were preventing this code from working as it should. Chord symbols seem broken in other ways too but not relevant to this feature.

NOTE: for future reference, the above comment about bugs preventing this actually applies to master (#3199), not this PR which is for 2.2.

@lasconic lasconic merged commit f79cf24 into musescore:2.2 Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants