New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #255791 - [MusicXML import] use lyric number as relative instead … #3306

Closed

lvinken wants to merge 1 commit into musescore:master from lvinken:255791-musicxml-relative-lyric-numbers

Contributor

lvinken commented Oct 4, 2017

…of as absolute line number


          fix #255791 - [MusicXML import] use lyric number as relative instead …

c5652e3

…of as absolute line number

Contributor

lasconic commented Dec 12, 2017

I had forgotten about this PR. Sorry for that.
I'm not sure it's the good thing to do. The testExtendedLyrics.xml doesn't work anymore. Somehow lyrics with the same "number" should be on the same line, but it's not the case in this test.

lasconic added the question label

Contributor Author

lvinken commented Dec 16, 2017

No problem, thanks for being critical and quality conscious. Apparently I missed some details, will have a look (again).

Contributor

Jojo-Schmitz commented Jan 14, 2018

Also it meanwhile needs a rebase

Contributor

lasconic commented Jan 16, 2018

No need to rebase. As highlighted above, the implementation is not ok. I will close the PR. @lvinken feel free to do another PR when you look into it again.

lasconic closed this

Contributor Author

lvinken commented Mar 3, 2018

As this is on the hit list for 2.2, I will have another look at it.

lvinken deleted the 255791-musicxml-relative-lyric-numbers branch

March 17, 2018 09:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet