fix #195146: rehearsalmark alignment #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tte-element is cloned and restyled. The restyled clone is always horizontal centered. Because of the bitwise OR in the restyle-method it can get centered AND right aligned! That is why I suggest unsetting all HMASK-flags before setting new horizontal-alignment-flags. The same should be right for the VMASK-flags. This fixes the problem descibed here: https://musescore.org/en/node/195036#comment-706826
lasconic
added a commit
that referenced
this pull request
Jan 11, 2018
blackears
pushed a commit
to blackears/MuseScore
that referenced
this pull request
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding a new rehearsalmark by double clicking the palette-element is cloned and restyled. The restyled clone from the palette is always horizontal centered before the restyling. Because of the bitwise OR in the restyle-method it can get centered AND right aligned! That is why I suggest unsetting all HMASK-flags before setting new horizontal-alignment-flags. The same should be right for the VMASK-flags. This fixes the problem descibed here: https://musescore.org/en/node/195036#comment-706826