Fix #268197: Up/down arrow keys in first/last line of text don't go to beginning/end #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWeiss
force-pushed
the
up-down-arrows-in-text
branch
from
4fdcc1b
to
1a77ffe
Compare
IsaacWeiss
force-pushed
the
up-down-arrows-in-text
branch
from
1a77ffe
to
74713f6
Compare
|
PR updated to make this change only on Mac. |
|
Is there any remaining question about this? |
lasconic
added a commit
that referenced
this pull request
Jan 31, 2018
…o beginning/end. See PR #3382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cursor is in the last line of a document or text box, standard behavior (at least on macOS) is that pressing the down arrow key moves the cursor to the end of the line. Similarly, when the cursor is in the first line, the up arrow key moves the cursor to the beginning of the line. This does not occur in MuseScore 2.1 or current development versions.
Multi-line text is not working at all in master currently, but as far as I can tell this fixes the editing behavior to match most macOS apps. However, it does not seem to affect text editing in e.g. Format / General Style / Header, Footer. Feedback appreciated.