fix #271450: double-click to set breaks on frames #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shouldn't this go to master too? |
|
It needs a bit of work (and I needed lunch) |
|
oops, my impatience once again ;-) |
|
Also, as mentioned, breaks aren't working on frames at all for master right now (well, as of when I submitted the PR) anyhow, so although in theory the same code would work, I can't actually verify this. Should be OK to merge anyhow, and I'm happy to submit a version with the static casts fixed if you'd like. |
|
It's merged in master already db751e9 |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression by adding support for frames to cmdToggleLayoutBreak(). Also makes the behavior more consistent with respect to toggling and also making line breaks replace page breaks and vice versa.
The same code would work in theory on master (just update the static_casts), but breaks seem completely broken on frames there right now, so I can't really verify.