Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #275259 score v.1.14 with Pedal do not open in 3.0 #3876

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

handrok
Copy link
Contributor

@handrok handrok commented Aug 17, 2018

add ability to read pedal from score v.1.14

@lasconic
Copy link
Contributor

It's probably worth to add a test case no ?

@lasconic
Copy link
Contributor

I meant a test case in mtest/libmscore/compat114

@RobFog
Copy link

RobFog commented Aug 18, 2018

This first commit message should include "Fix #275259" so that the issue gets closed automatically. The second commit message has a typo.

@handrok handrok force-pushed the fix#275259-pedal branch 2 times, most recently from 9220d0a to b391498 Compare August 18, 2018 13:32
@handrok handrok changed the title #275259 score v.1.14 with Pedal do not open in 3.0 Fix #275259 score v.1.14 with Pedal do not open in 3.0 Aug 18, 2018
@RobFog
Copy link

RobFog commented Aug 20, 2018

I think the first commit's message still needs a "Fix #275259". ;-)

@handrok handrok force-pushed the fix#275259-pedal branch 3 times, most recently from b08bb53 to 5e762fa Compare August 20, 2018 08:10
@handrok
Copy link
Contributor Author

handrok commented Aug 20, 2018

@RobFog thanks

@handrok
Copy link
Contributor Author

handrok commented Aug 20, 2018

folow up #3843 #3863
Add test case for ottava and textline (see link)

1) add pedal to unit tests

2) add textline to unit tests

3) add ottava to unit tests
@anatoly-os anatoly-os merged commit 8273775 into musescore:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants