fix #275834: crash when add slur to score #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattmcclinch could you please actualise the commit description, because now it doesn't fix the crash mentioned in the issue description, but prevents different kind of crash. |
mattmcclinch
force-pushed
the
275834-drop-slur
branch
from
e69d3c9
to
95e5b60
Compare
anatoly-os
reviewed
Sep 4, 2018
mscore/dragdrop.cpp
Outdated
| @@ -540,6 +541,9 @@ void ScoreView::dropEvent(QDropEvent* event) | |||
| } | |||
| event->acceptProposedAction(); | |||
| break; | |||
| case ElementType::SLUR: | |||
There was a problem hiding this comment.
What about some other element types? Don't they need the same clearing?
There was a problem hiding this comment.
As far as I know, SLUR is the only ElementType that will put the ScoreView into ViewState::EDIT upon drag/drop. But your point is well taken, and I have found a better way to do this.
mattmcclinch
force-pushed
the
275834-drop-slur
branch
from
95e5b60
to
5af04c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/275834.