partial fix #88861: show current staff name after instrument change #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tangential question (but brought to mind by the topic of changing properties of the staff following an instrument change): why is the "Staff Type Change" (a non-printing element currently found in the Text palette) separate from the Instrument Change element? |
|
The properties you can change aren't actually instrument-related - they are things like number of staff lines, whether time signatures are displayed, etc. As fir why it's on the text palette, I already filedan issue on that. I think it belongs on a "Layout" palette along with the stuff in Breaks & Spacer and/or Frames & Measures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often requested that after a mid-score instrument change, the staff names reflect the new name. This PR implements that. The issue referenced actually requests a UI to edit the staff name, and that's not unreasonable, but a task for another day.