fix #281369: "22mb" shows as "22ma", similar for "15ba" #4547
Conversation
|
2.x has the same issue, so is this actually by design? |
libmscore/style.cpp
Outdated
| @@ -406,9 +406,9 @@ static const StyleType styleTypes[] { | |||
| { Sid::ottava8VAText, "ottava8VAText", QString("<sym>ottavaAlta</sym>") }, | |||
| { Sid::ottava8VBText, "ottava8VBText", QString("<sym>ottavaBassaBa</sym>") }, | |||
| { Sid::ottava15MAText, "ottava15MAText", QString("<sym>quindicesimaAlta</sym>") }, | |||
| { Sid::ottava15MBText, "ottava15MBText", QString("<sym>quindicesimaBassa</sym>") }, | |||
| { Sid::ottava15MBText, "ottava15MBText", QString("<sym>quindicesimaBassaBa</sym>") }, | |||
There was a problem hiding this comment.
Don't you want to use quindicesimaBassaMb?
libmscore/style.cpp
Outdated
| { Sid::ottava22MAText, "ottava22MAText", QString("<sym>ventiduesimaAlta</sym>") }, | ||
| { Sid::ottava22MBText, "ottava22MBText", QString("<sym>ventiduesimaBassa</sym>") }, | ||
| { Sid::ottava22MBText, "ottava22MBText", QString("<sym>ventiduesimaBassaBa</sym>") }, |
There was a problem hiding this comment.
Don't you want to use ventiduesimaBassaMb?
libmscore/style.cpp
Outdated
| @@ -406,9 +406,9 @@ static const StyleType styleTypes[] { | |||
| { Sid::ottava8VAText, "ottava8VAText", QString("<sym>ottavaAlta</sym>") }, | |||
| { Sid::ottava8VBText, "ottava8VBText", QString("<sym>ottavaBassaBa</sym>") }, | |||
There was a problem hiding this comment.
Shouldn't this be ottavaBassaVb?
There was a problem hiding this comment.
So that the text will match the tooltips in the palette. What do 8ba, 15ba, and 22ba even mean? Don't we want 8vb, 15mb, and 22mb?
There was a problem hiding this comment.
Well, referring back to Behind Bars, it seems all of these are already correct after all.
There was a problem hiding this comment.
Hmm, OK so I guess we can rest that case.
Other option would be to provide multiple choices for those and including the French alternate sedicesima and its variants.
but not for 8ba. So let's fix the inconsistency
|
Fixed PR to use the glyphs matching the tooltips (8vb, 15mb, 22mb) and the names in the code ( But maybe we should change the tooltips (can we have superscript in those for the ottava alta?) and maybe even the names in code instead? There certainly is an inconsistency. |
|
Sorry, I do not understand anything of this. "8va", "15ma" and "22ma" are obviously short for the Italian words "ottava", "quindicesima" and "ventiduesima" (meaning 8th, 15th, 22th resp.). The texts actually shown in tooltips "8vb", "15mb" and "22mb" are completely meaningless and possibly stem from the (wrong) assumption that the final "a" in "8va", "15ma" and "22ma" stands for "alta" -- when actually it is the Italian feminine ending -- and could be replaced with a "b" from "bassa". So, those tooltips should read "8va bassa", "15ma bassa" and "22ma bassa" for completeness or leave out the "bassa", as it is obvious form the line shape that these are down transpositions. Or am I missing something and completely out of topic? |
|
Hmm, OK, so that 'va' and 'mb' is basically the same as the "st", "nd", "rd" and "th" appended to numbers in English, right? Just wonder what all those other SMuFL glyphs are for then. |
|
Guess I gould add those tooltip (including worklspace) and inspector text changes to #4492 |
… for alta and bassa see also PR musescore#4547 Clefs were having the same issue, so changed those too
|
@Jojo-Schmitz : yes, "-va" and "-ma" are relatives of "-st", "-nd", etc. except that they are no longer used in modern language (outside of music jargon, the only remains are the small superscript "o" and "a" as in "4°" for "quarto" or "8ª" for "ottava"). "mb" does not exist. The tooltips themselves do not show the lines, but the palette entries they are displayed for do show the lines and the transposition direction is evident. So, adding "... alta" or "... bassa" might be convenient for clarity, but if room is scarce, it can be avoided, I think. |
|
It is the tooltip on those lines in the palette, actually it is the cell name that turns into a tooltip. And there is enough space |
|
So just let's close it. |
… for alta and bassa see also PR musescore#4547 Clefs were having the same issue, so changed those too
… for alta and bassa see also PR musescore#4547 Clefs were having the same issue, so changed those too
… fixes * Change sharps, flats and naturals to their unicode counterparts * Fix #281028: remove superfluos double spaces * Add missing "the" * Fix #280842: change [Tablature] to (Tablature) for instruments * fix #280470: Inconsistent reference to menu entry navigation * Translate MusicXML import error message prefix see https://musescore.org/en/node/281133 * Improve message on importing pre-3.0 scores and also enabling it for pre-2.0 scores * Fix #281369: Ottava bassa shows as "8vb", while 15ma and 22ma is used for alta and bassa see also PR musescore#4547 Clefs were having the same issue, so changed those too * Improve one text in Preferences > I/O and remove another as that is no longer true * Yet another ellipsis
but not for 8ba. So let's fix the inconsistency.