fix #283405: "Ped. *" has line visible in advanced workspace #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but not in master palette. Also for both "Ped." lines continueText is set in master palette but missing in the palette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but not in master palette. Also for both "Ped." lines continueText is set in master palette but missing in the palette.
Not sure about the track info in the palette, seems superfluous? At least it doesn't show in the scores. Same for all lines in the workspaces' lines palette.
Also there's another bug lurking: continueText is not taken when applying those lines, not via master palette nor, after this fix, via the advanced workspace. Still having them in the workspace is the right thing, to match the master palette.