Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow loading old drm and style files #4851

Merged
merged 2 commits into from May 20, 2019

Conversation

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 1, 2019

@Jojo-Schmitz

This comment has been minimized.

Copy link
Contributor Author

Jojo-Schmitz commented Apr 1, 2019

I wonder whether someting like this could/should also be done for style files, unfortunately this gets loaded in libmscore, so a dialog there won't be possible. A more indirect method is needed...

@@ -568,8 +568,11 @@ void EditDrumset::load()
while (e.readNextStartElement()) {
if (e.name() == "museScore") {
if (e.attribute("version") != MSC_VERSION) {
QMessageBox::critical(this, tr("Drumset too old"), tr("MuseScore cannot load this drumset file."));
return;
QMessageBox::StandardButton b = QMessageBox::warning(this, tr("Drumset too old"),

This comment has been minimized.

Copy link
@anatoly-os

anatoly-os Apr 2, 2019

Contributor

We discussed these strings somewhere few month ago...
At least, Drumset too old is not a correct English sentence afaiu.

This comment has been minimized.

Copy link
@Jojo-Schmitz

Jojo-Schmitz Apr 2, 2019

Author Contributor

Drumset file too old?
It is not supposed to be a sentence, but a window title.
To what should it get changed then, if at all?

@Jojo-Schmitz Jojo-Schmitz force-pushed the Jojo-Schmitz:drm branch from bee1b34 to d07f686 May 7, 2019
@Jojo-Schmitz Jojo-Schmitz changed the title allow loading old drm files allow loading old drm and style files May 7, 2019
@anatoly-os anatoly-os merged commit a2c0130 into musescore:master May 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jojo-Schmitz Jojo-Schmitz deleted the Jojo-Schmitz:drm branch May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.