allow loading old drm and style files #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether someting like this could/should also be done for style files, unfortunately this gets loaded in libmscore, so a dialog there won't be possible. A more indirect method is needed... |
anatoly-os
reviewed
Apr 2, 2019
mscore/editdrumset.cpp
Outdated
| @@ -568,8 +568,11 @@ void EditDrumset::load() | |||
| while (e.readNextStartElement()) { | |||
| if (e.name() == "museScore") { | |||
| if (e.attribute("version") != MSC_VERSION) { | |||
| QMessageBox::critical(this, tr("Drumset too old"), tr("MuseScore cannot load this drumset file.")); | |||
| return; | |||
| QMessageBox::StandardButton b = QMessageBox::warning(this, tr("Drumset too old"), | |||
There was a problem hiding this comment.
We discussed these strings somewhere few month ago...
At least, Drumset too old is not a correct English sentence afaiu.
There was a problem hiding this comment.
Drumset file too old?
It is not supposed to be a sentence, but a window title.
To what should it get changed then, if at all?
Jojo-Schmitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://musescore.org/en/node/267856