fix MSVC/MinGW compiler warnings #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Jojo-Schmitz
force-pushed
the
warnings
branch
from
7b5b11a
to
fbf626c
Compare
anatoly-os
reviewed
Sep 4, 2019
Jojo-Schmitz
force-pushed
the
warnings
branch
from
fbf626c
to
4ffcd72
Compare
Jojo-Schmitz
commented
Sep 4, 2019
Jojo-Schmitz
force-pushed
the
warnings
branch
from
d817508
to
3d15b0f
Compare
dmitrio95
reviewed
Sep 29, 2019
mscore/palette/palettetree.cpp
Outdated
| @@ -270,34 +270,34 @@ bool PalettePanel::read(XmlReader& e) | |||
| _name = e.attribute("name"); | |||
| _type = Type::Unknown; | |||
| while (e.readNextStartElement()) { | |||
| const QStringRef t(e.name()); | |||
| if (t == "gridWidth") | |||
| const QStringRef s(e.name()); | |||
There was a problem hiding this comment.
Probably same as above, if we need to rename this variable
There was a problem hiding this comment.
But naming it tag gives another warning, C4458 in MSVC
Jojo-Schmitz
force-pushed
the
warnings
branch
3 times, most recently
from
e73b251
to
adfb2ca
Compare
|
Adding fixes for a couple more (read: new) warnings, adding a missingg accessibility string. |
and also fix a compiler warning fixed earlier in a different (and better) way, see musescore#4963
|
and a few new warnings just cropped up :-( |
anatoly-os
pushed a commit
that referenced
this pull request
Oct 2, 2019
fix MSVC/MinGW compiler warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.