fix #294082: TAB - Mixing mensural value symbols and beaming in historic tablatures is broken. #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a really specific concern, but I do know that the relationship between stem and beam layout is very delicate - tons of things can go wrong, like bad placement of slashes on grace notes, bad layout of rhythmic slash notation, bad layout of cross-staff beams, etc - if things get thrown off. So it scares me a little to add this code for all cases. Could we maybe do it only for tab staves? EDIT: or find a different place to call TabDurationSymbol::layout2() |
…ric tablatures is broken. TabDurationSymbol::layout2() is responsible for setting the _beamLength for the tab duration symbol, which is used to determine the length of the line to draw. Problem is, TabDurationSymbol::layout2() is only ever called from Chord::layoutStem(), and Chord::layoutStem() is not being called at all, except from ChordRest::removeDeleteBeam(). Therefore, _beamLength is always equal to 0, which results in zero-length lines being drawn. This adds a call to TabDurationSymbol::layout2() from Chord::layout2(), so that _beamLength can be set to the correct value.
mattmcclinch
force-pushed
the
294082-layout-stem
branch
from
50409cf
to
f94c4ca
Compare
|
It seems natural to call |
anatoly-os
added a commit
that referenced
this pull request
Oct 2, 2019
fix #294082: TAB - Mixing mensural value symbols and beaming in historic tablatures is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/294082.
TabDurationSymbol::layout2()is responsible for setting the_beamLengthfor the tab duration symbol, which is used to determine the length of the line to draw. Problem is,TabDurationSymbol::layout2()is only ever called fromChord::layoutStem(), andChord::layoutStem()is not being called at all, except fromChordRest::removeDeleteBeam(). Therefore,_beamLengthis always equal to 0, which results in zero-length lines being drawn.This adds a call to
Chord::layoutStem()TabDurationSymbol::layout2()fromLayoutContext::collectPage()Chord::layout2(), so that_beamLengthcan be set to the correct value.