Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #305106: Crash when applying preferences with no scores open #6057

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented May 7, 2020

Resolves: #305106

Added a missing nullptr check for mscore->currentScoreView() inside PreferenceDialog::apply(), fixing a crash that occurred if the user attempted to apply preferences when there were no scores open.

Also changed ScoreView::panSettings() to return a reference instead of a pointer, eliminating the need for an unnecessary nullptr check.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Added a missing nullptr check for mscore->currentScoreView() inside PreferenceDialog::apply(), fixing a crash that occurred if the user attempted to apply preferences when there were no scores open.

Also changed ScoreView::panSettings() to return a reference instead of a pointer, eliminating the need for an unnecessary nullptr check.
@anatoly-os anatoly-os merged commit a35dc40 into musescore:3.x May 11, 2020
anatoly-os added a commit that referenced this pull request May 12, 2020
…erences-with-no-scores-open

Fix #305106: Crash when applying preferences with no scores open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants