Fix #305106: Crash when applying preferences with no scores open #6057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #305106
Added a missing
nullptr
check formscore->currentScoreView()
insidePreferenceDialog::apply()
, fixing a crash that occurred if the user attempted to apply preferences when there were no scores open.Also changed
ScoreView::panSettings()
to return a reference instead of a pointer, eliminating the need for an unnecessarynullptr
check.