fix #305079: fret diagrams shifted upwards compared to 3.4.2 #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vtest failures are expected and ok. |
2 tasks
|
The mtest failures are not to be expected though I guess, https://travis-ci.org/github/musescore/MuseScore/jobs/685020984#L4252-L4414 and https://travis-ci.org/github/musescore/MuseScore/jobs/685020984#L4488-L4550 |
|
They are also expected, they just need to be manually fixed :) |
Fixed by changing a default style value. The layout code for fret diagrams was fixed fairly significantly between the last versions, and I thoroughly checked it to make sure it is correct. So, that can only mean that the problem is an incorrect default style value which previously compensated for layout errors.
jthistle
force-pushed
the
305079-fret-shifted-up
branch
from
1e2337a
to
8906a2c
Compare
|
My mistake, that's not at all true - they were unexpected failures. But I hope now that they are fixed. |
anatoly-os
added a commit
that referenced
this pull request
May 12, 2020
fix #305079: fret diagrams shifted upwards compared to 3.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://musescore.org/en/node/305079
Fixed by changing a default style value. The layout code for fret diagrams was fixed fairly significantly between the last versions, and I thoroughly checked it to make sure it is correct. So, that can only mean that the problem is an incorrect default style value which previously compensated for layout errors.