Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306524: Control playback speed with the keyboard #6190

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Jun 9, 2020

Resolves: #306524

Implemented three new commands that increase, decrease, and reset the playback speed to 100%. The speed increment defaults to 5% but is configurable via an advanced preference. The new commands are not assigned default keyboard shortcuts but are configurable by the user.

Also renamed “relative tempo” to “playback speed” in the relevant code, since that more accurately describes what it actually is. This distinction will become more important later if (or when) MuseScore gains true relative-tempo control at the score level (as opposed to the playback/transport level).

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Implemented three new commands that increase, decrease, and reset the playback speed to 100%. The speed increment defaults to 5% but is configurable via an advanced preference. The new commands are not assigned default keyboard shortcuts but are configurable by the user.

Also renamed “relative tempo” to “playback speed” in the relevant code, since that more accurately describes what it actually is. This distinction will become more important later if (or when) MuseScore gains true relative-tempo control at the score level (as opposed to the playback/transport level).
@Spire42 Spire42 mentioned this pull request Jun 9, 2020
12 tasks
@anatoly-os anatoly-os merged commit 49522d7 into musescore:3.x Jun 10, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…ith-the-keyboard

Fix #306524: Control playback speed with the keyboard
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 12, 2021
vpereverzev pushed a commit that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants