AppImage: Bundle OpenSSL to fix Save Online on recent distros #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shoogle
commented
Jun 22, 2020
shoogle
commented
- I signed CLA
- I made sure the code in the PR follows the coding rules
- I made sure the code compiles on my machine
- I made sure there are no unnecessary changes in the code
- I made sure the title of the PR reflects the core meaning of the issue you are solving
- I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
- [N/A] I made sure the commit message title starts with "fix #424242:" if there is a related issue
- [N/A] I created the test (mtest, vtest, script test) to verify the changes I made
shoogle
force-pushed
the
appimage-openssl
branch
2 times, most recently
from
c8b5247
to
eb0f028
Compare
shoogle
force-pushed
the
appimage-openssl
branch
from
eb0f028
to
fa7d44c
Compare
shoogle
force-pushed
the
appimage-openssl
branch
from
fa7d44c
to
41089de
Compare
shoogle
changed the title
|
Affects more than just Chromebooks. Recent distros have dropped OpenSSL 1.0 in favour of a newer version, but Qt 5.9 is still built against the old version because that's all that is available in older distros. |
1 task
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.