Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #309066 + fix #283996: the same headers/footers are used for the score and all its parts (4.x) #6451

Closed
wants to merge 1 commit into from

Conversation

SKefalidis
Copy link
Contributor

Resolves: https://musescore.org/en/node/309066, https://musescore.org/en/node/283996

Moved headers/footers from the Movements class to Score.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n\a] I created the test (mtest, vtest, script test) to verify the changes I made

@SKefalidis SKefalidis changed the title fix #309066 + fix #283996: the same headers/footers are used for the score and all its parts fix #309066 + fix #283996: the same headers/footers are used for the score and all its parts (4.x) Aug 14, 2020
@Jojo-Schmitz
Copy link
Contributor

Note to self: #6450 for 3.x

@SKefalidis
Copy link
Contributor Author

@anatoly-os this is the master version of #6450

@Jojo-Schmitz
Copy link
Contributor

#6450 got manually merged into master so this here is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants