fix #309108: add support for quality after extension #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chord symbol parser was implemented many years ago and it supports msot common notations, but a few used in some regions slipped through the track. In particular, C7o and C7+. These place the quality after the extension. There was partial support for C7+, and it parsed OK, but a bug never noticed until now is that it was also marked as not "understandable", which now prevents playback. This commit fixes the bug that prevented C7+ from fully working, but adding a null handler for an empty token in the loop during which the "+" is processed and replaced with an empty token. It also adds the same processing for C7o.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/309108
The chord symbol parser was implemented many years ago
and it supports msot common notations, but a few used in some regions
slipped through the track. In particular, C7o and C7+.
These place the quality after the extension.
There was partial support for C7+, and it parsed OK,
but a bug never noticed until now is that it was also marked
as not "understandable", which now prevents playback.
This commit fixes the bug that prevented C7+ from fully working,
but adding a null handler for an empty token in the loop
during which the "+" is processed and replaced with an empty token.
It also adds the same processing for C7o.