fix #312029: don't scale fingering with note size #7195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/312029 A recent change to text layout for the sake of scale tuplet numbers caused fingerings to start scaling with note size. On one hand this might seem desirable, in practice it seems not. After discussion on Telegram, it was decided to keep fingerings full size when making notes small. The original change - to have text layout respect the text element's own "mag" setting - is good. The fix here is to prevent changes to note sizes from affecting the fingering "mag".
njvdberg
approved these changes
Dec 31, 2020
49 tasks
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 12, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/312029
A recent change to text layout for the sake of scale tuplet numbers
caused fingerings to start scaling with note size.
On one hand this might seem desirable, in practice it seems not.
After discussion on Telegram, it was decided to keep fingerings
full size when making notes small.
The original change - to have text layout respect
the text element's own "mag" setting - is good.
The fix here is to prevent changes to note sizes
from affecting the fingering "mag".