Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317747: Measure number appears after edit in first measure after section break with intervening frame #7568

Conversation

mattmcclinch
Copy link
Contributor

Resolves: https://musescore.org/en/node/317747.

This was just a simple case of forgetting to update mb with the result of mb->findPotentialSectionBreak().

@mattmcclinch
Copy link
Contributor Author

This is handled in #7569.

@MarcSabatella
Copy link
Contributor

Hah, I see you submitted yours first, nice job! Really, I'm not sure the second change I made is strictly needed, certainly it isn't just for this exact case. But it could be in other cases, and certainly shouldn't hurt.

@mattmcclinch
Copy link
Contributor Author

I included a nullptr check in mine. You might consider doing the same in yours in both places, since findPotentialSectionBreak() can potentially return nullptr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants