Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAISY] Fix #303450: Text in voice 2 not placed correctly #7863

Closed
wants to merge 1 commit into from
Closed

[DAISY] Fix #303450: Text in voice 2 not placed correctly #7863

wants to merge 1 commit into from

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Apr 1, 2021

Resolves: https://musescore.org/en/node/303450

Text and other annotations were always being exported to Voice 1 regardless of the voice that the text or annotation actually belongs to.

To-do:

  • Check export works as expected
  • Check import works as expected (can't do this yet because import is currently disabled in MU4)
  • Add tests and reference files

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 2, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
cb2ea12 
Backport of musescore#7863
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Apr 2, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 2, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
4f86382 
Backport of musescore#7863
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 2, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
a128cc1 
Backport of musescore#7863
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 10, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
728eccc 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
7e6b8dc 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
e8814e1 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
99a2ea9 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
18bd6b7 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
e47693c 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
aaa998a 
Backport of musescore#7863, resp. duplicate of musescore#7870, possibly a culprit for mtest
lailures
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
af48082 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
f102ffe 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
6d5f6f9 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
9fb0de7 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
3496fca 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
206e37f 
Backport of musescore#7863, resp. duplicate of musescore#7870
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
e013bfb 
Backport of musescore#7863
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
cd20c1e 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
afaa9bd 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
77e48cd 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
7ec1720 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
c4343f7 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@shoogle @Jojo-Schmitz
Fix #303450 MusicXML: Text in voice 2 not placed correctly
1e7608e 
Backport of musescore#7863, resp. duplicate of musescore#7870, part 3
@shoogle
Copy link
Contributor Author

shoogle commented Jul 6, 2023

Closing for now. May revisit this later.

@shoogle shoogle closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoogle @Jojo-Schmitz