Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test to fix #25559: show splash screen on linux #869

Merged
merged 1 commit into from
Apr 28, 2014
Merged

test to fix #25559: show splash screen on linux #869

merged 1 commit into from
Apr 28, 2014

Conversation

barafael
Copy link
Contributor

@barafael
Copy link
Contributor Author

Doesn't seem to affect other platforms.

lasconic added a commit that referenced this pull request Apr 28, 2014
test to fix #25559: show splash screen on linux
@lasconic lasconic merged commit 9f0475b into musescore:master Apr 28, 2014
@barafael barafael deleted the 25559-showsplash branch April 28, 2014 14:30
@barafael barafael restored the 25559-showsplash branch May 1, 2014 13:02
@barafael barafael deleted the 25559-showsplash branch May 1, 2014 13:02
@lasconic
Copy link
Contributor

lasconic commented May 1, 2014

I'm afraid I will have to revert this change. When MuseScore quits unexpectedly, we are displaying a dialog to ask the user if he wants to continue last session. This dialog is currently positioned behind the splashscreen on Mac. Uncommenting the line makes it works currently. I will try on Windows. It would be cool if you could try on Linux.

@lasconic
Copy link
Contributor

lasconic commented May 1, 2014

It's not the case on Windows. If it's ok on Linux, I will add the statement for Mac OSX only.

@barafael
Copy link
Contributor Author

barafael commented May 1, 2014

On Linux the window is above the splash screen. Is the dialog already
toplevel?
QSplashscreen is on the highest level by definition I think...

2014-05-01 21:54 GMT+02:00 Nicolas Froment notifications@github.com:

I'm afraid I will have to revert this change. When MuseScore quits
unexpectedly, we are displaying a dialog to ask the user if he wants to
continue last session. This dialog is currently positioned behind the
splashscreen on Mac. Uncommenting the line makes it works currently. I will
try on Windows. It would be cool if you could try on Linux.

Reply to this email directly or view it on GitHubhttps://github.com//pull/869#issuecomment-41949518
.

@barafael
Copy link
Contributor Author

barafael commented May 1, 2014

2014-05-01 23:16 GMT+02:00 Rafael Bachmann triolenzunge@gmail.com:

On Linux the window is above the splash screen. Is the dialog already
toplevel?
QSplashscreen is on the highest level by definition I think...

2014-05-01 21:54 GMT+02:00 Nicolas Froment notifications@github.com:

I'm afraid I will have to revert this change. When MuseScore quits

unexpectedly, we are displaying a dialog to ask the user if he wants to
continue last session. This dialog is currently positioned behind the
splashscreen on Mac. Uncommenting the line makes it works currently. I will
try on Windows. It would be cool if you could try on Linux.

Reply to this email directly or view it on GitHubhttps://github.com//pull/869#issuecomment-41949518
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants