-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the Dockerfile #522
Conversation
Pull Request Test Coverage Report for Build 1279
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine. 👍
Co-authored-by: srenfo <14216995+srenfo@users.noreply.github.com>
Co-authored-by: srenfo <14216995+srenfo@users.noreply.github.com>
Co-authored-by: srenfo <14216995+srenfo@users.noreply.github.com>
FYI there is #491 for the failing coveralls checks. |
Yeah, annoying that I have to add a test somewhere just to make coveralls happy... Maybe we should give another tool a try 🤔 |
I think it's a false positive. I don't see your changes in this PR impacting the coverage. I suspect it's comparing the wrong things... maybe coverage across runs from different branches? |
@srenfo good to merge? |
It just now successfully built and ran on my machine. 🥇 I don't have a merge button, so please go ahead. 😄 |
The container builds but there are issues when running it. Would appreciate someone to have a look at it as well.
Justification for dropping Alpine as base container: https://pythonspeed.com/articles/alpine-docker-python/