Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tidal-pitch-glide #288

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Create tidal-pitch-glide #288

merged 3 commits into from
Feb 19, 2023

Conversation

fracnesco
Copy link
Contributor

Added one example on the hacks folder to create pitch glide setting a parameter of an active synth

@fracnesco
Create tidal-pitch-glide
e0bbc23 
Added one example on the hacks folder to create pitch glide setting a parameter of an active synth
telephon
telephon reviewed Feb 18, 2023
View reviewed changes
hacks/tidal-pitch-glide Outdated Show resolved Hide resolved
telephon
telephon reviewed Feb 18, 2023
View reviewed changes
hacks/tidal-pitch-glide Outdated Show resolved Hide resolved
telephon
telephon reviewed Feb 19, 2023
View reviewed changes
Copy link
Contributor

@telephon telephon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave out the comments, I think, because they just repeat what the code says? Also no extra parentheses needed around synth.isNil. I can fix that, but while you are at it :)

Thanks for the contribution!

@telephon telephon merged commit 80f3cb8 into musikinformatik:develop Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telephon telephon telephon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fracnesco @telephon