Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External state #118

Merged
merged 9 commits into from
Oct 26, 2022
Merged

External state #118

merged 9 commits into from
Oct 26, 2022

Conversation

musoke
Copy link
Owner

@musoke musoke commented Oct 26, 2022

No description provided.

BREAKING CHANGE: Adding an external potential is now quite
different.
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #118 (5c2cb4c) into main (ccb941b) will decrease coverage by 2.78%.
The diff coverage is 70.14%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   87.70%   84.92%   -2.79%     
==========================================
  Files           8        8              
  Lines         488      524      +36     
==========================================
+ Hits          428      445      +17     
- Misses         60       79      +19     
Impacted Files Coverage Δ
src/config.jl 100.00% <ø> (ø)
src/grids.jl 88.57% <0.00%> (-1.29%) ⬇️
src/pencil_grids.jl 100.00% <ø> (ø)
src/UltraDark.jl 82.50% <53.57%> (-15.92%) ⬇️
src/time_step.jl 92.85% <75.00%> (-7.15%) ⬇️
src/output.jl 82.60% <77.77%> (-1.18%) ⬇️
src/summary.jl 68.29% <95.00%> (+0.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Correct the docstring for `total_mass`, so that it has the right name in
it.
Add a function to compute the total energy in the scalar field.
Add a loop over auxiliary steps for each external state.  This allows
external states to arbitrarily modify grids and themselves.
@musoke musoke merged commit 9aeee60 into main Oct 26, 2022
@musoke musoke deleted the external-state branch October 26, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant