Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plots in examples from Plots.jl to Makie.jl #158

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Convert plots in examples from Plots.jl to Makie.jl #158

merged 1 commit into from
Aug 30, 2023

Conversation

musoke
Copy link
Owner

@musoke musoke commented Aug 30, 2023

No description provided.

@musoke musoke changed the title Move example plots from Plots to Makie Convert plots in example from Plots.jl to Makie.jl Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9a0aa3) 85.04% compared to head (92e5f7f) 85.04%.

❗ Current head 92e5f7f differs from pull request most recent head 0a96fda. Consider uploading reports for the commit 0a96fda to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files           8        8           
  Lines         602      602           
=======================================
  Hits          512      512           
  Misses         90       90           
Files Changed Coverage Δ
src/config.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@musoke musoke force-pushed the makie branch 2 times, most recently from 15e6a8e to 1ee154d Compare August 30, 2023 21:54
@musoke musoke linked an issue Aug 30, 2023 that may be closed by this pull request
@musoke musoke force-pushed the makie branch 2 times, most recently from 75847fa to f1a3464 Compare August 30, 2023 22:05
@musoke musoke changed the title Convert plots in example from Plots.jl to Makie.jl Convert plots in examples from Plots.jl to Makie.jl Aug 30, 2023
Plots.jl seems to break quite easily, especially in CI and clusters.
Makie.jl seems not to have this problem.

Fixes #82
@musoke musoke merged commit a6f5232 into main Aug 30, 2023
12 checks passed
@musoke musoke deleted the makie branch August 30, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move plots to makie
1 participant