UNIX/Linux build and other fixes. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjnewbury
force-pushed
the
master
branch
6 times, most recently
from
875121b
to
f1af551
Compare
glob.h needs to be included earlier to set defines in defs.h. In particular, it must be before unistd.h.
Since -std=c11 is being used, explicit feature_test_macros must be set appropriately to provide compatible definitions of standard functions, such as usleep().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets things working on fully up to date Gentoo Linux with GCC-6.3.0. There are still warnings which should be addressed, mostly not checking the return value of various functions.
The only contentious part of this patch series is the inclusion of -DBSD which is obviously not correct for Windows builds. It was the old default though. It probably should have it's own variable in the make file to make it clearer that it needs to be changed depending on build system.