Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qr codes #1096

Merged
merged 27 commits into from
Nov 27, 2023
Merged

feat: qr codes #1096

merged 27 commits into from
Nov 27, 2023

Conversation

SputNikPlop
Copy link
Collaborator

This is my partial attempt on how to get #904 implemented. Any feedback and help is welcome.

lib/l10n/app_bn.arb Outdated Show resolved Hide resolved
lib/l10n/app_zh_Hant.arb Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/screens/settings/qr.dart Outdated Show resolved Hide resolved
lib/screens/settings/qr.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
SputNikPlop and others added 4 commits November 7, 2023 09:47
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
pubspec.yaml Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
lib/models/qr_code.dart Outdated Show resolved Hide resolved
@kevmo314
Copy link
Contributor

kevmo314 commented Nov 7, 2023

Screenshot_20231107-154322

I don't seem to see the QR code?

Also I think this is on the right track, but let's make the following changes from a UI perspective:

  1. Let's make the QR code more discoverable. Next to the search icon, add a qr code icon https://fonts.google.com/icons?selected=Material+Icons:qr_code:&icon.query=code that when tapped shows the qr code.
  2. When the QR icon is tapped, close the drawer
  3. When the QR icon is tapped, show it in a bottom sheet like how the search channels feature works
  4. Change @muxfd to /muxfd
  5. Change the blue font color to white.
  6. Tapping on the bottom sheet should change the background (I can't seem to trigger the background change right now)

The biggest issue right now is the feature isn't super discoverable so this would make it easier to find.

lib/models/qr_code.dart Outdated Show resolved Hide resolved
@SputNikPlop
Copy link
Collaborator Author

@kevmo314 Ok good points made, also that makes more sense since on the issue I had to drop the modal sheet because I could only get that to work with iOS 13

lib/models/qr_code.dart Outdated Show resolved Hide resolved
@SputNikPlop
Copy link
Collaborator Author

SputNikPlop commented Nov 20, 2023

Screen Shot 2023-11-20 at 1 39 29 PM
@kevmo314 what do you think about moving the /username part outside the card part? maybe a bit more of an edge up top?

@kevmo314
Copy link
Contributor

Screen Shot 2023-11-20 at 1 39 29 PM @kevmo314 what do you think about moving the /username part outside the card part? maybe a bit more of an edge up top?

My 2c on the UI

  1. Move the name outside the QR code.
  2. Make the gradient background the entire bottom sheet's background.
  3. Give the QR code a white rounded background (the gradient you have now), leave the padding as-is
  4. Make the QR code circles instead of squares: https://github.com/theyakka/qr.flutter/blob/master/example/lib/main_screen.dart#L34C22-L53

@SputNikPlop SputNikPlop merged commit c196c21 into main Nov 27, 2023
4 checks passed
@SputNikPlop SputNikPlop deleted the qr-cde branch November 27, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants