-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: qr codes #1096
feat: qr codes #1096
Conversation
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
I don't seem to see the QR code? Also I think this is on the right track, but let's make the following changes from a UI perspective:
The biggest issue right now is the feature isn't super discoverable so this would make it easier to find. |
@kevmo314 Ok good points made, also that makes more sense since on the issue I had to drop the modal sheet because I could only get that to work with iOS 13 |
|
My 2c on the UI
|
This is my partial attempt on how to get #904 implemented. Any feedback and help is welcome.