fix: add tts unit test #1122
Merged
fix: add tts unit test #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that this can be caused by the unit tests as well refactor: added some variables to check if the queue is empty and the length of it refactor: make _queue public queue
kevmo314
reviewed
Nov 28, 2023
SputNikPlop
reviewed
Nov 28, 2023
SputNikPlop
reviewed
Nov 28, 2023
…p the next message
kevmo314
reviewed
Nov 29, 2023
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
refactor: still a WIP (final test is still broken), cannot get last test to work properly or for the flutter test to interact with the method channel, it will never go into the handler.
|
Tests seem to fail on CI? https://github.com/muxable/rtchat/actions/runs/7051914298/job/19195849795?pr=1122 |
Yes, I'm going to try to sort that last test without the use of mockito today so that we're passing. The last push I did was broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1102