Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch scanner libraries #1124

Merged
merged 21 commits into from
Jan 16, 2024
Merged

fix: switch scanner libraries #1124

merged 21 commits into from
Jan 16, 2024

Conversation

SputNikPlop
Copy link
Collaborator

Ok so the other library has some issues on the latest version of iOS. Slowly want to migrate this over so any feedback is appreciated.

Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine if you've tested it, but let's migrate everything all at once. It doesn't seem useful to keep two barcode scanning libraries around and it bloats the download size.

lib/screens/settings/activity_feed.dart Outdated Show resolved Hide resolved
lib/screens/settings/activity_feed.dart Outdated Show resolved Hide resolved
lib/screens/settings/audio_sources.dart Outdated Show resolved Hide resolved
lib/screens/settings/quick_links.dart Outdated Show resolved Hide resolved
lib/screens/settings/audio_sources.dart Outdated Show resolved Hide resolved
lib/screens/settings/third_party.dart Outdated Show resolved Hide resolved
lib/share_channel.dart Outdated Show resolved Hide resolved
@SputNikPlop SputNikPlop enabled auto-merge (squash) January 16, 2024 18:30
@SputNikPlop SputNikPlop merged commit 43a5252 into main Jan 16, 2024
4 checks passed
@SputNikPlop SputNikPlop deleted the scanner branch January 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants