Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vocalization for each message #1162

Merged
merged 16 commits into from
Jan 17, 2024
Merged

fix: add vocalization for each message #1162

merged 16 commits into from
Jan 17, 2024

Conversation

SputNikPlop
Copy link
Collaborator

This should resolve #1152 though needs to be tested.

lib/components/chat_history/message.dart Outdated Show resolved Hide resolved
@jessielw
Copy link
Collaborator

jessielw commented Jan 6, 2024

I think this is what @kevmo314 was referring to @SputNikPlop.

Can you take a look at the changes I just added to #1162 and let me know if it looks like this is going down the correct path?

Note: I didn't modify the changes made to message.dart

@jessielw jessielw requested a review from kevmo314 January 6, 2024 00:11
lib/tts_isolate.dart Outdated Show resolved Hide resolved
@jessielw
Copy link
Collaborator

@kevmo314 can you take a look at the latest changes and let me know how things are looking?

Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just two minor comments.

lib/tts_isolate.dart Outdated Show resolved Hide resolved
lib/tts_isolate.dart Outdated Show resolved Hide resolved
lib/tts_isolate.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. For testing, try adding a button that starts the service and set the tts channel. You should hear it vocalize messages out of that channel.

lib/tts_isolate.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@jessielw jessielw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, seems to be working properly

@jessielw jessielw merged commit 2ca0e72 into main Jan 17, 2024
4 checks passed
@jessielw jessielw deleted the 1152 branch January 17, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For each message, add its vocalization to the speak system
3 participants