-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add vocalization for each message #1162
Conversation
I think this is what @kevmo314 was referring to @SputNikPlop. Can you take a look at the changes I just added to #1162 and let me know if it looks like this is going down the correct path? Note: I didn't modify the changes made to |
@kevmo314 can you take a look at the latest changes and let me know how things are looking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just two minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. For testing, try adding a button that starts the service and set the tts channel. You should hear it vocalize messages out of that channel.
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out, seems to be working properly
This should resolve #1152 though needs to be tested.