feat: add button to disable tts #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo314
requested changes
Jan 19, 2024
SputNikPlop
commented
Jan 20, 2024
kevmo314
reviewed
Jan 22, 2024
kevmo314
reviewed
Mar 5, 2024
android/app/src/main/kotlin/com/rtirl/chat/NotificationService.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/com/rtirl/chat/NotificationService.kt
Outdated
Show resolved
Hide resolved
refactor: remove "disableTTS", no longer needed here
fix: correctly stop speaking before sending there are too many messages fix: cancel notification properly when there are too many messages after speaking the the message
…s needed if text to speech is killed anywhere else in the application
jessielw
approved these changes
Mar 15, 2024
kevmo314
approved these changes
Mar 15, 2024
android/app/src/main/kotlin/com/rtirl/chat/TextToSpeechSingleton.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add a button to disable tts. I added an icon instead of the text because I was unsure which to add so lemme know if I need to go to text or if you want to switch the icon to something like https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Avoice_over_off%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4024