fix: update get vocalization in the isolate #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo314
reviewed
Mar 22, 2024
feat: create ttsmodel directly inside of the isolate and update it in real time based on the prefs listener feat: now updates isbotmuted, isemotemuted, ispreludemuted, israndomvoiceenaabled, pitch, and speed feat: uses a new method in TextToSpeechPlugin that accepts pitch & speed to update the native code refactor: getVocalization accepts isprelude muted directly from the ttsmodel instead of a bool variable
…e with pitch/speed refactor: debug print all potential errors in TextToSpeechPlugin
…uted, _isEmoteMuted, _isPreludeMuted, _speed, and _pitch refactor: removed code to create an empty constructor
kevmo314
reviewed
Mar 26, 2024
refactor: add an internal class method by updateFromJson and TtsModel.fromJson refactor: removed setters setPitch, setSpeed, setPreludeMuted, setEmoteMuted, setBotMuted, and setRandomVoiceEnabled
… of all of the setters
refactor: fix twitchmessagemodel
SputNikPlop
approved these changes
Mar 27, 2024
SputNikPlop
changed the title
kevmo314
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188