fix: landscape qr #1247
Merged
fix: landscape qr #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevmo314 I think this is ready now here is how it looks: |
|
Oh here it is in landscape |
Can you make the width fit the content for landscape? Otherwise this looks good. |
So just remove all the excess white got it. |
|
@kevmo314 Take a look |
kevmo314
approved these changes
May 24, 2024
Wolfof420Street
pushed a commit
to Wolfof420Street/rtchat
that referenced
this pull request
Jun 17, 2024
* fix: landscape qr * fix: use dialog class * fix: avatar size adusted to enable scanning * fix: remove white sidebar space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the qr code not working horizontally, it isn't quite perfect I think but I'll let you take a look at the following pictures.
The old qr:
Portrait - I like how the text is above the bottom navigation bar here.
Landscape - It overflow and the qr code doesn't work because the profile picture is way to big.
The new qr:
Portrait - The text is now very low and behind the bottom navigation bar.
Landscape - The qr now works but I think the text is a little big.
I like how the old portrait text was and kind of how it looked in landscape but the qr code didn't work, this new way works but I don't quite like the text. Maybe we make the text smaller in the new landscape ui matching the old way without having to scroll and being over the navigation bar in portrait mode. I think I am missing something though, let me know the best way to do this.