Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump audioplayers version #1250

Merged
merged 1 commit into from
Jun 9, 2024
Merged

chore: bump audioplayers version #1250

merged 1 commit into from
Jun 9, 2024

Conversation

kevmo314
Copy link
Contributor

@kevmo314 kevmo314 commented Jun 3, 2024 •
edited
Loading

Adds more explicit audio annotations so maybe it will behave better with Spotify and other applications.

@SputNikPlop
Copy link
Collaborator

Maybe we should do this?
https://developer.android.com/media/optimize/audio-focus

SputNikPlop
SputNikPlop approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps somewhat, I tried a more in depth fix on my pr since eventually we have to handle alerts and more

@SputNikPlop SputNikPlop merged commit 065fe22 into main Jun 9, 2024
5 checks passed
@SputNikPlop SputNikPlop deleted the bump-audioplayers branch June 9, 2024 06:37
Wolfof420Street pushed a commit to Wolfof420Street/rtchat that referenced this pull request Jun 9, 2024
@kevmo314 @Wolfof420Street
chore: bump audioplayers version (muxable#1250)
14c0efc
Wolfof420Street pushed a commit to Wolfof420Street/rtchat that referenced this pull request Jun 17, 2024
@kevmo314 @Wolfof420Street
chore: bump audioplayers version (muxable#1250)
872d582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SputNikPlop SputNikPlop SputNikPlop approved these changes

@juaoose juaoose Awaiting requested review from juaoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmo314 @SputNikPlop