-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: localize the vocalization in TtsModel #1280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo314
had a problem deploying
to
android-internal
July 7, 2024 03:57
— with
GitHub Actions
Failure
kevmo314
changed the title
Localize the vocalization in TtsModel
feat: localize the vocalization in TtsModel
Jul 8, 2024
Three steps are necessary here:
final locale = basicLocaleListResolution(WidgetsBinding.instance.platformDispatcher.locales, AppLocalizations.supportedLocales) https://api.flutter.dev/flutter/widgets/basicLocaleListResolution.html
final l10n = lookupAppLocalizations(Locale("en"));
|
kevmo314
had a problem deploying
to
android-internal
July 8, 2024 06:21
— with
GitHub Actions
Failure
kevmo314
had a problem deploying
to
android-internal
July 8, 2024 06:26
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
July 9, 2024 08:54
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 9, 2024 08:54
— with
GitHub Actions
Failure
…tead of a BuildContext
kevmo314
had a problem deploying
to
ios-testflight
July 11, 2024 05:27
— with
GitHub Actions
Failure
kevmo314
had a problem deploying
to
android-internal
July 11, 2024 05:27
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
July 12, 2024 20:32
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 12, 2024 20:32
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
July 15, 2024 19:26
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 15, 2024 19:26
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
July 15, 2024 19:58
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 15, 2024 19:58
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 16, 2024 02:20
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
July 16, 2024 02:27
— with
GitHub Actions
Failure
SputNikPlop
temporarily deployed
to
android-internal
July 16, 2024 02:29
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 16, 2024 02:40
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
July 16, 2024 02:40
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 16, 2024 19:39
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
July 16, 2024 19:39
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 16, 2024 19:51
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
July 16, 2024 20:01
— with
GitHub Actions
Inactive
@SputNikPlop looks good to me |
kevmo314
commented
Jul 17, 2024
SputNikPlop
temporarily deployed
to
ios-testflight
July 17, 2024 21:32
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 17, 2024 21:32
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 23, 2024 20:01
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
July 23, 2024 20:01
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
July 23, 2024 20:16
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
July 23, 2024 20:20
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This doesn't work yet, we will need to figure out how to load the build context outside of a widget context in the tts isolate.
Localize the vocalization in
TtsModel
to address #1035.AppLocalizations
inlib/models/tts.dart
andlib/screens/settings/tts.dart
.getVocalization
method inTtsModel
to useAppLocalizations
for constructing vocalization strings.BuildContext
parameter togetVocalization
method.SystemMessageModel
vocalizations to use localized strings.TextToSpeechScreen
to useAppLocalizations
.lib/l10n/app_en.arb
,lib/l10n/app_es.arb
,lib/l10n/app_fr.arb
,lib/l10n/app_de.arb
, andlib/l10n/app_ja.arb
.For more details, open the Copilot Workspace session.