fix: guard setState calls in message_input.dart with mounted checks #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard the `setState` calls in `lib/components/message_input.dart` with mounted checks. * Add a mounted check before the `setState` call on line 113 to ensure `_textEditingController` is cleared only if the widget is still mounted. * Add a mounted check before the `setState` call on line 120 to ensure `_pendingSend` list is updated only if the widget is still mounted. * Add a mounted check before the `setState` call on line 126 to ensure `_pendingSend` list is updated only if the widget is still mounted. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/muxable/rtchat?shareId=XXXX-XXXX-XXXX-XXXX).
kevmo314
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
approved these changes
Aug 3, 2024
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard the
setStatecalls inlib/components/message_input.dartwith mounted checks.setStatecall on line 113 to ensure_textEditingControlleris cleared only if the widget is still mounted.setStatecall on line 120 to ensure_pendingSendlist is updated only if the widget is still mounted.setStatecall on line 126 to ensure_pendingSendlist is updated only if the widget is still mounted.For more details, open the Copilot Workspace session.