-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ep strapi v4 upgrade typescript #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updating components to be v4 compliant - Updated package.json to exclude core Strapi deps per rec.
- This was an accident :'(
- Updated permissions to use Strapi permission schemes - Added thumbnail proxy to avoid Strapi CSR limitations - Created new ListPagination component - Now using useFormik hook for form validation
- Made all static strings into translated placholders - Ignore yarn-error.log file -
- Issue stemmed from incorrect types - Opportunity to use the formatDate and formatTime from react-intl - Updated playback, asset and upload ids to word break if needed - Deprecated luxon
- Make it so that titles are ellipsised after 2 rows
- Re-enabled routing for the app
Closed
- Upgraded @mux/mux-node - Upgraded axios - Upgraded @mux/videojs-kit - Upgraded lodash - Upgraded styled-components
- Updated strapi peer dependency to 4.0.5 (min)
- Updated to reflect v4 updates - Added verbiage for filing issues - Removed public perms since we now have this programmatically available - Added FAQ for rebuilding Strapi instance (common question)
- Reorganized and restylized flow of README - Added Strapi v3 install instructions
- Made MuxAssets visible in the Content Type Builder
- Updated logic to stop upload when Title is not defined - Added validation to check that Title is more than 3 letters - Added translation for title length validation
- Added shallow Status type from Strapi's design-system - Updated webhook handler to search for asset_id - Uploaded details modal to expose upload error
py-pkulk
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
- Created a new UploadError component for displaying errors durin upload - Added translation files for UploadError component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to upgrade the plugin to support Strapi's v4 release.
Updated to include necessary migrations to Strapi's new v4 APIs including the design-system.